]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
cxgb3/l2t: Fix undefined behaviour
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Fri, 29 Mar 2019 15:27:26 +0000 (10:27 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 31 May 2019 13:45:13 +0000 (06:45 -0700)
commit0e9fbbee52f8481faab34970386f0ec1debc1b3f
tree2f8df9b8a917c80fe084ccdda61d778ddcbb11af
parent59ccb4e49bfb06e2696b819626a718bb34ff4810
cxgb3/l2t: Fix undefined behaviour

[ Upstream commit 76497732932f15e7323dc805e8ea8dc11bb587cf ]

The use of zero-sized array causes undefined behaviour when it is not
the last member in a structure. As it happens to be in this case.

Also, the current code makes use of a language extension to the C90
standard, but the preferred mechanism to declare variable-length
types such as this one is a flexible array member, introduced in
C99:

struct foo {
        int stuff;
        struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last. Which is beneficial
to cultivate a high-quality code.

Fixes: e48f129c2f20 ("[SCSI] cxgb3i: convert cdev->l2opt to use rcu to prevent NULL dereference")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/chelsio/cxgb3/l2t.h