]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
bonding: don't call update_speed_duplex() under spinlocks
authorVeaceslav Falico <vfalico@redhat.com>
Tue, 12 Mar 2013 06:31:32 +0000 (06:31 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 28 Mar 2013 19:17:07 +0000 (12:17 -0700)
commit0eb06e7a1faccfe1e809312011399611e3e4301e
treee6e6715d4f3d5949e662b3000707816911e80a86
parent6ea0e8abf3ca8bc8be51282da8f857cad4bfcd19
bonding: don't call update_speed_duplex() under spinlocks

[ Upstream commit 876254ae2758d50dcb08c7bd00caf6a806571178 ]

bond_update_speed_duplex() might sleep while calling underlying slave's
routines. Move it out of atomic context in bond_enslave() and remove it
from bond_miimon_commit() - it was introduced by commit 546add79, however
when the slave interfaces go up/change state it's their responsibility to
fire NETDEV_UP/NETDEV_CHANGE events so that bonding can properly update
their speed.

I've tested it on all combinations of ifup/ifdown, autoneg/speed/duplex
changes, remote-controlled and local, on (not) MII-based cards. All changes
are visible.

Signed-off-by: Veaceslav Falico <vfalico@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/bonding/bond_main.c