]> git.ipfire.org Git - thirdparty/openvpn.git/commit
Repair "tcp server queue overflow" brokenness, more <stdbool.h> fallout.
authorGert Doering <gert@greenie.muc.de>
Mon, 11 Mar 2013 20:03:20 +0000 (21:03 +0100)
committerGert Doering <gert@greenie.muc.de>
Tue, 12 Mar 2013 12:40:26 +0000 (13:40 +0100)
commit0eb398501fab9c016b9b6008682c43873c4a6188
treebcc59e7e65cc30b42cf7cea2f64468e945aab091
parentdc63e06b2c366f74752c8baa61b0f173d62511ad
Repair "tcp server queue overflow" brokenness, more <stdbool.h> fallout.

Return value of mbuf_len() wrong - it's returning a length value, not
a yes/no value - so when the queue length approached 65 (full!), it
still only returned "1", leading to MBUF overflow later on.  Change
from "bool" to "unsigned int", misbehaviour gone...

This fixes OpenVPN trac ticket #263.

Signed-off-by: Gert Doering <gert@greenie.muc.de>
Acked-by: Arne Schwabe <arne@rfc2549.org>
Acked-by: Peter Caprioli <petercap@kth.se>
Message-Id: <20130312100706.GN953@greenie.muc.de>
URL: http://article.gmane.org/gmane.network.openvpn.devel/7396
Signed-off-by: Gert Doering <gert@greenie.muc.de>
src/openvpn/mbuf.h