]> git.ipfire.org Git - thirdparty/linux.git/commit
nvme: fix PCIe subsystem reset controller state transition
authorNilay Shroff <nilay@linux.ibm.com>
Wed, 14 Jan 2026 07:24:13 +0000 (12:54 +0530)
committerKeith Busch <kbusch@kernel.org>
Wed, 14 Jan 2026 15:21:31 +0000 (07:21 -0800)
commit0edb475ac0a7d153318a24d4dca175a270a5cc4f
tree825d4a4bd06f950dca700514d19be4b9495eba9f
parent84164acba33158208c2b0e8e5607bdd43edc0dd4
nvme: fix PCIe subsystem reset controller state transition

The commit d2fe192348f9 (“nvme: only allow entering LIVE from CONNECTING
state”) disallows controller state transitions directly from RESETTING
to LIVE. However, the NVMe PCIe subsystem reset path relies on this
transition to recover the controller on PowerPC (PPC) systems.

On PPC systems, issuing a subsystem reset causes a temporary loss of
communication with the NVMe adapter. A subsequent PCIe MMIO read then
triggers EEH recovery, which restores the PCIe link and brings the
controller back online. For EEH recovery to proceed correctly, the
controller must transition back to the LIVE state.

Due to the changes introduced by commit d2fe192348f9 (“nvme: only allow
entering LIVE from CONNECTING state”), the controller can no longer
transition directly from RESETTING to LIVE. As a result, EEH recovery
exits prematurely, leaving the controller stuck in the RESETTING state.

Fix this by explicitly transitioning the controller state from RESETTING
to CONNECTING and then to LIVE. This satisfies the updated state
transition rules and allows the controller to be successfully recovered
on PPC systems following a PCIe subsystem reset.

Cc: stable@vger.kernel.org
Fixes: d2fe192348f9 ("nvme: only allow entering LIVE from CONNECTING state")
Reviewed-by: Daniel Wagner <dwagner@suse.de>
Signed-off-by: Nilay Shroff <nilay@linux.ibm.com>
Signed-off-by: Keith Busch <kbusch@kernel.org>
drivers/nvme/host/pci.c