]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
dmaengine: usb-dmac: Fix PM reference leak in usb_dmac_probe()
authorYu Kuai <yukuai3@huawei.com>
Tue, 6 Jul 2021 12:45:21 +0000 (20:45 +0800)
committerSasha Levin <sashal@kernel.org>
Thu, 26 Aug 2021 12:37:48 +0000 (08:37 -0400)
commit0eee458057c0132e5ddaa1b6fe2080b1b6668ec0
tree1dd538087e4ccb8daab722554ae76e89ebb0c6a6
parent53723b7be26ef31ad642ce5ffa8b42dec16db40e
dmaengine: usb-dmac: Fix PM reference leak in usb_dmac_probe()

[ Upstream commit 1da569fa7ec8cb0591c74aa3050d4ea1397778b4 ]

pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by moving the error_pm label above the pm_runtime_put() in
the error path.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Link: https://lore.kernel.org/r/20210706124521.1371901-1-yukuai3@huawei.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/dma/sh/usb-dmac.c