]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ext4: add lockdep annotations for i_data_sem
authorTheodore Ts'o <tytso@mit.edu>
Fri, 1 Apr 2016 05:31:28 +0000 (01:31 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Apr 2016 06:45:25 +0000 (15:45 +0900)
commit0f1aafe300072b2d09e71ec5f18deca77f9b3463
treee370b3d9ab9dbeeb0fcdec91096d87ca83ef1acf
parentdcc6f2ddcbe6fb23a6e9a76d14b2862fffa6a127
ext4: add lockdep annotations for i_data_sem

commit daf647d2dd58cec59570d7698a45b98e580f2076 upstream.

With the internal Quota feature, mke2fs creates empty quota inodes and
quota usage tracking is enabled as soon as the file system is mounted.
Since quotacheck is no longer preallocating all of the blocks in the
quota inode that are likely needed to be written to, we are now seeing
a lockdep false positive caused by needing to allocate a quota block
from inside ext4_map_blocks(), while holding i_data_sem for a data
inode.  This results in this complaint:

  Possible unsafe locking scenario:

        CPU0                    CPU1
        ----                    ----
   lock(&ei->i_data_sem);
                                lock(&s->s_dquot.dqio_mutex);
                                lock(&ei->i_data_sem);
   lock(&s->s_dquot.dqio_mutex);

Google-Bug-Id: 27907753

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/ext4/ext4.h
fs/ext4/move_extent.c
fs/ext4/super.c