]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
nilfs2: determine empty node blocks as corrupted
authorRyusuke Konishi <konishi.ryusuke@gmail.com>
Wed, 4 Sep 2024 08:13:08 +0000 (17:13 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 4 Oct 2024 14:29:22 +0000 (16:29 +0200)
commit0f28b3b51fc1d9ef0e768ce03d262ea88447344b
treebe605d6f950b701266b040de7c51943e1ee9a390
parent21839b6fbc3c41b3e374ecbdb0cabbbb2c53cf34
nilfs2: determine empty node blocks as corrupted

[ Upstream commit 111b812d3662f3a1b831d19208f83aa711583fe6 ]

Due to the nature of b-trees, nilfs2 itself and admin tools such as
mkfs.nilfs2 will never create an intermediate b-tree node block with 0
child nodes, nor will they delete (key, pointer)-entries that would result
in such a state.  However, it is possible that a b-tree node block is
corrupted on the backing device and is read with 0 child nodes.

Because operation is not guaranteed if the number of child nodes is 0 for
intermediate node blocks other than the root node, modify
nilfs_btree_node_broken(), which performs sanity checks when reading a
b-tree node block, so that such cases will be judged as metadata
corruption.

Link: https://lkml.kernel.org/r/20240904081401.16682-3-konishi.ryusuke@gmail.com
Fixes: 17c76b0104e4 ("nilfs2: B-tree based block mapping")
Signed-off-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Cc: Lizhi Xu <lizhi.xu@windriver.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/nilfs2/btree.c