]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
selftests/net: Ensure assert() triggers in psock_tpacket.c
authorWake Liu <wakel@google.com>
Sat, 9 Aug 2025 06:20:13 +0000 (14:20 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 3 Dec 2025 11:45:09 +0000 (12:45 +0100)
commit0f2fce4b19caefe3397c8731087e1ceae49972a9
treea96dfe4de2f6dbe0a214f76df58c5df6fa2d6f16
parent00e6691f6cfba8f0123a5adf14d6c228e897fc40
selftests/net: Ensure assert() triggers in psock_tpacket.c

[ Upstream commit bc4c0a48bdad7f225740b8e750fdc1da6d85e1eb ]

The get_next_frame() function in psock_tpacket.c was missing a return
statement in its default switch case, leading to a compiler warning.

This was caused by a `bug_on(1)` call, which is defined as an
`assert()`, being compiled out because NDEBUG is defined during the
build.

Instead of adding a `return NULL;` which would silently hide the error
and could lead to crashes later, this change restores the original
author's intent. By adding `#undef NDEBUG` before including <assert.h>,
we ensure the assertion is active and will cause the test to abort if
this unreachable code is ever executed.

Signed-off-by: Wake Liu <wakel@google.com>
Link: https://patch.msgid.link/20250809062013.2407822-1-wakel@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
tools/testing/selftests/net/psock_tpacket.c