]> git.ipfire.org Git - thirdparty/git.git/commit
ls-remote: leakfix for not clearing server_options
authorXing Xin <xingxin.xx@bytedance.com>
Tue, 8 Oct 2024 03:38:19 +0000 (03:38 +0000)
committerJunio C Hamano <gitster@pobox.com>
Tue, 8 Oct 2024 17:22:10 +0000 (10:22 -0700)
commit0f490d270aa015f0bcb6a99c666eaa5b83f5d375
tree686074db80bc4d3e5859ac8f76fa2cfe4b3cd90d
parent148bc7bf4b482edd7919e3071542abeb5d7ea4af
ls-remote: leakfix for not clearing server_options

Ensure `server_options` is properly cleared using `string_list_clear()`
in `builtin/ls-remote.c:cmd_ls_remote`.

Although we cannot yet enable `TEST_PASSES_SANITIZE_LEAK=true` for
`t/t5702-protocol-v2.sh` due to other existing leaks, this fix ensures
that "git-ls-remote" related server options tests pass the sanitize leak
check:

  ...
  ok 12 - server-options are sent when using ls-remote
  ok 13 - server-options from configuration are used by ls-remote
  ...

Signed-off-by: Xing Xin <xingxin.xx@bytedance.com>
Reviewed-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/ls-remote.c