]> git.ipfire.org Git - thirdparty/FORT-validator.git/commit
Refactors resulting from the issue #83 review
authorAlberto Leiva Popper <ydahhrk@gmail.com>
Mon, 6 Jun 2022 22:16:12 +0000 (17:16 -0500)
committerAlberto Leiva Popper <ydahhrk@gmail.com>
Tue, 7 Jun 2022 03:34:49 +0000 (22:34 -0500)
commit0f579ac34c01fb46294ed4e2aa78d51de60ebabc
tree4795b22827eddc0011e4f056b04f097d97f24010
parent5cfb2f66dd6d28ab31c5736be02c4afe336a153f
Refactors resulting from the issue #83 review

Mostly quality of life improvements.

On the other hand, it looks like the notfatal hash table API was being
used incorrectly. HASH_ADD_KEYPTR can OOM, but `errno` wasn't being
catched.

Fixing this is nontrivial, however, because strange `reqs_error`
functions are in the way, and that's a spaggetti I decided to avoid.
Instead, I converted HASH_ADD_KEYPTR usage to the fatal hash table API.
That's the future according to #40, anyway.

I don't think this has anything to do with #83, though.
src/data_structure/uthash_nonfatal.h
src/object/tal.c
src/output_printer.c
src/output_printer.h
src/reqs_errors.c
src/rrdp/db/db_rrdp_uris.c
src/rtr/db/db_table.c
src/rtr/db/db_table.h
src/rtr/db/vrps.c
src/validation_handler.c
src/visited_uris.c