]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
x86: bpf_jit: fix compilation of large bpf programs
authorAlexei Starovoitov <ast@plumgrid.com>
Fri, 22 May 2015 22:42:55 +0000 (15:42 -0700)
committerJiri Slaby <jslaby@suse.cz>
Wed, 10 Jun 2015 09:18:09 +0000 (11:18 +0200)
commit0fa9520e7b08f00138cf9a4a95d066492cbcc18d
treef5dc9163c8f51684855c581f542edb13d6584d43
parent8c35200a686d3647b1ed44c2e803019b529a3ee2
x86: bpf_jit: fix compilation of large bpf programs

[ Upstream commit 3f7352bf21f8fd7ba3e2fcef9488756f188e12be ]

x86 has variable length encoding. x86 JIT compiler is trying
to pick the shortest encoding for given bpf instruction.
While doing so the jump targets are changing, so JIT is doing
multiple passes over the program. Typical program needs 3 passes.
Some very short programs converge with 2 passes. Large programs
may need 4 or 5. But specially crafted bpf programs may hit the
pass limit and if the program converges on the last iteration
the JIT compiler will be producing an image full of 'int 3' insns.
Fix this corner case by doing final iteration over bpf program.

Fixes: 0a14842f5a3c ("net: filter: Just In Time compiler for x86-64")
Reported-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: Alexei Starovoitov <ast@plumgrid.com>
Tested-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
arch/x86/net/bpf_jit_comp.c