]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ALSA: hda: cs35l56: Propagate ASP TX source control errors
authorCássio Gabriel <cassiogabrielcontato@gmail.com>
Thu, 23 Apr 2026 13:11:31 +0000 (10:11 -0300)
committerTakashi Iwai <tiwai@suse.de>
Mon, 27 Apr 2026 11:48:41 +0000 (13:48 +0200)
commit0faacc0841d66f3cf51989c10a83f3a82d52ff2c
tree914b382030bb98a43f04a332cb036bd35b580814
parent254f49634ee16a731174d2ae34bc50bd5f45e731
ALSA: hda: cs35l56: Propagate ASP TX source control errors

cs35l56_hda_mixer_get() ignores regmap_read() and
cs35l56_hda_mixer_put() ignores regmap_update_bits_check().

This makes the ASP TX source controls report success when a regmap
access fails. The write path returns no change instead of an error,
and the read path continues after a failed read instead of aborting
the control callback.

Propagate the regmap errors, matching the posture and volume controls
in this driver.

Fixes: 73cfbfa9caea ("ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifier")
Cc: stable@vger.kernel.org
Signed-off-by: Cássio Gabriel <cassiogabrielcontato@gmail.com>
Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20260423-alsa-cs35l56-asp-tx-source-errors-v1-1-17ea7c62ec31@gmail.com
sound/hda/codecs/side-codecs/cs35l56_hda.c