]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ext4: lock i_mutex when truncating orphan inodes
authorTheodore Ts'o <tytso@mit.edu>
Thu, 27 Dec 2012 06:42:48 +0000 (01:42 -0500)
committerPaul Gortmaker <paul.gortmaker@windriver.com>
Mon, 10 Feb 2014 21:11:29 +0000 (16:11 -0500)
commit0fd8d8773fd8c2a136efbc0f0e705e51ee181be9
treed98b0645a6aa5d37609b5465208b5ed52d9dd462
parent34de201cb95e93565d55a5bb5e12997133eeffd5
ext4: lock i_mutex when truncating orphan inodes

commit 721e3eba21e43532e438652dd8f1fcdfce3187e7 upstream.

Commit c278531d39 added a warning when ext4_flush_unwritten_io() is
called without i_mutex being taken.  It had previously not been taken
during orphan cleanup since races weren't possible at that point in
the mount process, but as a result of this c278531d39, we will now see
a kernel WARN_ON in this case.  Take the i_mutex in
ext4_orphan_cleanup() to suppress this warning.

Reported-by: Alexander Beregalov <a.beregalov@gmail.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Reviewed-by: Zheng Liu <wenqing.lz@taobao.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
fs/ext4/super.c