]> git.ipfire.org Git - thirdparty/haproxy.git/commit
BUG/MINOR: quic-be: Wrong retry_source_connection_id check
authorFrederic Lecaille <flecaille@haproxy.com>
Fri, 27 Jun 2025 05:53:28 +0000 (07:53 +0200)
committerFrederic Lecaille <flecaille@haproxy.com>
Fri, 27 Jun 2025 05:59:12 +0000 (07:59 +0200)
commit1045623cb8e84aaa46cc85e0f17b597b61101aba
tree29d2511187448db1a3bb7decb6d6010f90310b37
parent299a441110cbd337cbdc36bb749315d5c0257c38
BUG/MINOR: quic-be: Wrong retry_source_connection_id check

This commit broke the QUIC backend connection to servers without address validation
or retry activated:

  MINOR: quic-be: address validation support implementation (RETRY)

Indeed the retry_source_connection_id transport parameter was already checked as
as if it was required, as if the peer (server) was always using the address validation.
Furthermore, relying on ->odcid.len to ensure a retry token was received is not
correct.

This patch ensures the retry_source_connection_id transport parameter is checked
only when a retry token was received (->retry_token != NULL). In this case
it also checks that this transport parameter is present when a retry token
has been received (tx_params->retry_source_connection_id.len != 0).

No need to backport.
src/quic_tp.c