]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
hpet: Optimize local variable data type in hpet_alloc()
authorThorsten Blum <thorsten.blum@toblux.com>
Wed, 10 Jul 2024 21:52:39 +0000 (23:52 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 31 Jul 2024 11:12:02 +0000 (13:12 +0200)
commit104831a17518796fb29e803fe07eb87ce9df884d
treeff00f04a994d5a4f346de6c625f73d70de2fbda4
parent4d41a49c4660eca5214d8b6f85cc8569c7d77599
hpet: Optimize local variable data type in hpet_alloc()

The local variable period uses at most 32 bits and can be a u32 instead
of unsigned long. The upper 32 bits are all 0 after masking and right
shifting cap by HPET_COUNTER_CLK_PERIOD_SHIFT and can be discarded.

Since do_div() casts the divisor to u32 anyway, changing the data type
of period to u32 also removes the following Coccinelle/coccicheck
warning reported by do_div.cocci:

  WARNING: do_div() does a 64-by-32 division, please consider using div64_ul instead

Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20240710215238.799239-2-thorsten.blum@toblux.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/char/hpet.c