]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net/sched: taprio: fix use-after-free in advance_sched() on schedule switch
authorVinicius Costa Gomes <vinicius.gomes@intel.com>
Sat, 11 Apr 2026 01:57:57 +0000 (18:57 -0700)
committerJakub Kicinski <kuba@kernel.org>
Fri, 17 Apr 2026 02:06:40 +0000 (19:06 -0700)
commit105425b1969c5affe532713cfac1c0b320d7ac2b
tree9b28df01aeeaf8301d72be480209e1c776164d3f
parent1e9e7fd839b7f22b46762059c6f3e576b3e6e179
net/sched: taprio: fix use-after-free in advance_sched() on schedule switch

In advance_sched(), when should_change_schedules() returns true,
switch_schedules() is called to promote the admin schedule to oper.
switch_schedules() queues the old oper schedule for RCU freeing via
call_rcu(), but 'next' still points into an entry of the old oper
schedule. The subsequent 'next->end_time = end_time' and
rcu_assign_pointer(q->current_entry, next) are use-after-free.

Fix this by selecting 'next' from the new oper schedule immediately
after switch_schedules(), and using its pre-calculated end_time.
setup_first_end_time() sets the first entry's end_time to
base_time + interval when the schedule is installed, so the value
is already correct.

The deleted 'end_time = sched_base_time(admin)' assignment was also
harmful independently: it would overwrite the new first entry's
pre-calculated end_time with just base_time.

Fixes: a3d43c0d56f1 ("taprio: Add support adding an admin schedule")
Reported-by: Junxi Qian <qjx1298677004@gmail.com>
Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/sched/sch_taprio.c