]> git.ipfire.org Git - thirdparty/libvirt.git/commit
Revert "report error when virProcessGetStatInfo() is unable to parse data"
authorMichal Privoznik <mprivozn@redhat.com>
Tue, 18 Jan 2022 11:40:09 +0000 (12:40 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Thu, 20 Jan 2022 16:51:07 +0000 (17:51 +0100)
commit105dace22cc7b5b18d72a4dcad4a2cf386ce5c99
tree6ae2a2e3603a6d1d6198ab4ec32483c2437a6053
parentadd089d9f51e14f770c7f71bb7464db9a1a9a4e6
Revert "report error when virProcessGetStatInfo() is unable to parse data"

This reverts commit 938382b60ae5bd1f83b5cb09e1ce68b9a88f679a.

Turns out, the commit did more harm than good. It changed
semantics on some public APIs. For instance, while
qemuDomainGetInfo() previously did not returned an error it does
now. While the calls to virProcessGetStatInfo() is guarded with
virDomainObjIsActive() it doesn't necessarily mean that QEMU's
PID is still alive. QEMU might be gone but we just haven't
realized it (e.g. because the eof handler thread is waiting for a
job).

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2041610
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
src/ch/ch_driver.c
src/qemu/qemu_driver.c
src/util/virprocess.c