]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
drm/amd/display: Fix uninitialized variable use which breaks full LTO
authorCalvin Owens <calvin@wbinvd.org>
Thu, 12 Mar 2026 17:13:34 +0000 (10:13 -0700)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 17 Mar 2026 16:11:49 +0000 (12:11 -0400)
commit10718159890bc99cbcc7b5a38dade05df335e797
tree446e2fd12cca16cc961b47267b95966aca1e7f33
parent6270b1a5dab94665d7adce3dc78bc9066ed28bdd
drm/amd/display: Fix uninitialized variable use which breaks full LTO

Commit e1b385726f7f ("drm/amd/display: Add additional checks for PSP
footer size") introduced a use of an uninitialized stack variable
in dm_dmub_sw_init() (region_params.bss_data_size).

Interestingly, this seems to cause no issue on normal kernels. But when
full LTO is enabled, it causes the compiler to "optimize" out huge
swaths of amdgpu initialization code, and the driver is unusable:

    amdgpu 0000:03:00.0: [drm] Loading DMUB firmware via PSP: version=0x07002F00
    amdgpu 0000:03:00.0: sw_init of IP block <dm> failed 5
    amdgpu 0000:03:00.0: amdgpu_device_ip_init failed
    amdgpu 0000:03:00.0: Fatal error during GPU init

It surprises me that neither gcc nor clang emit a warning about this: I
only found it by bisecting the LTO breakage.

Fix by using the bss_data_size field from fw_meta_info_params, as was
presumably intended.

Fixes: e1b385726f7f ("drm/amd/display: Add additional checks for PSP footer size")
Signed-off-by: Calvin Owens <calvin@wbinvd.org>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
(cherry picked from commit b7f1402f6ad24cc6b9a01fa09ebd1c6559d787d0)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c