]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ses: Fix problems with simple enclosures
authorJames Bottomley <James.Bottomley@HansenPartnership.com>
Tue, 8 Dec 2015 17:00:31 +0000 (09:00 -0800)
committerZefan Li <lizefan@huawei.com>
Wed, 26 Oct 2016 15:15:36 +0000 (23:15 +0800)
commit10c6ff6e59c741a94fc1cc819755f7b76e8db2c3
treedd2eba1862808997b34e5afdfc4dadaa56c54ac6
parentd8e33a2789a888f62f1ee2a0289509947c77bc65
ses: Fix problems with simple enclosures

commit 3417c1b5cb1fdc10261dbed42b05cc93166a78fd upstream.

Simple enclosure implementations (mostly USB) are allowed to return only
page 8 to every diagnostic query.  That really confuses our
implementation because we assume the return is the page we asked for and
end up doing incorrect offsets based on bogus information leading to
accesses outside of allocated ranges.  Fix that by checking the page
code of the return and giving an error if it isn't the one we asked for.
This should fix reported bugs with USB storage by simply refusing to
attach to enclosures that behave like this.  It's also good defensive
practise now that we're starting to see more USB enclosures.

Reported-by: Andrea Gelmini <andrea.gelmini@gelma.net>
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Zefan Li <lizefan@huawei.com>
drivers/scsi/ses.c