]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
sctp: correct bounds check in sctp_setsockopt_auth_key
authorVlad Yasevich <vladislav.yasevich@hp.com>
Wed, 3 Sep 2008 08:02:19 +0000 (01:02 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 8 Sep 2008 10:20:21 +0000 (03:20 -0700)
commit113de4111795af1245a84368c233f25699999908
treebee30e2d21d97d2760455579394ce1c21a458ab5
parent1c6f8e1945a2b8317e5dad8fb5cfc882bd35b2b8
sctp: correct bounds check in sctp_setsockopt_auth_key

[ Upstream commit 328fc47ea0bcc27d9afa69c3ad6e52431cadd76c ]

The bonds check to prevent buffer overlflow was not exactly
right.  It still allowed overflow of up to 8 bytes which is
sizeof(struct sctp_authkey).

Since optlen is already checked against the size of that struct,
we are guaranteed not to cause interger overflow either.

Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/sctp/socket.c