]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
JFFS2: fix unmount regression
authorArtem Bityutskiy <artem.bityutskiy@linux.intel.com>
Thu, 23 Aug 2012 07:10:07 +0000 (10:10 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 12 Oct 2012 20:47:25 +0000 (05:47 +0900)
commit11452ff5e0d11327103e362cc176cd201c3815ef
tree4a4824616791e0dfaa84bd7d6228d71277ad24a4
parent8c6924929b212796dcab375c9ac482baef142205
JFFS2: fix unmount regression

commit a445f784ae5558a3da680aa6b39ed53c95a551c1 upstream.

This patch fixes regression introduced by
"8bdc81c jffs2: get rid of jffs2_sync_super". We submit a delayed work in order
to make sure the write-buffer is synchronized at some point. But we do not
flush it when we unmount, which causes an oops when we unmount the file-system
and then the delayed work is executed.

This patch fixes the issue by adding a "cancel_delayed_work_sync()" infocation
in the '->sync_fs()' handler. This will make sure the delayed work is canceled
on sync, unmount and re-mount. And because VFS always callse 'sync_fs()' before
unmounting or remounting, this fixes the issue.

Reported-by: Ludovic Desroches <ludovic.desroches@atmel.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Tested-by: Ludovic Desroches <ludovic.desroches@atmel.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/jffs2/super.c