]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
efi: ssdt: Don't free memory if ACPI table was loaded successfully
authorArd Biesheuvel <ardb@kernel.org>
Fri, 14 Oct 2022 10:25:52 +0000 (12:25 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Oct 2022 10:22:57 +0000 (12:22 +0200)
commit11497fd69cd2282538ec6eb4cda1d16fc061233d
tree65c646e5263df48f946629eb316dededda184224
parentc2a000ad03bb3a0d0f389adcfc9f8c61622da363
efi: ssdt: Don't free memory if ACPI table was loaded successfully

commit 4b017e59f01097f19b938f6dc4dc2c4720701610 upstream.

Amadeusz reports KASAN use-after-free errors introduced by commit
3881ee0b1edc ("efi: avoid efivars layer when loading SSDTs from
variables"). The problem appears to be that the memory that holds the
new ACPI table is now freed unconditionally, instead of only when the
ACPI core reported a failure to load the table.

So let's fix this, by omitting the kfree() on success.

Cc: <stable@vger.kernel.org> # v6.0
Link: https://lore.kernel.org/all/a101a10a-4fbb-5fae-2e3c-76cf96ed8fbd@linux.intel.com/
Fixes: 3881ee0b1edc ("efi: avoid efivars layer when loading SSDTs from variables")
Reported-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/firmware/efi/efi.c