]> git.ipfire.org Git - thirdparty/haproxy.git/commit
BUG/MEDIUM: http-act: Don't replace URI if path is not found or invalid
authorChristopher Faulet <cfaulet@haproxy.com>
Fri, 8 Apr 2022 08:44:21 +0000 (10:44 +0200)
committerChristopher Faulet <cfaulet@haproxy.com>
Fri, 8 Apr 2022 08:45:31 +0000 (10:45 +0200)
commit114e759d5d5e9d93e0c5993f49e3de3ec5dcbf3b
tree52a641956fc72e9f9cad2add25509846c6e22a76
parent21ac0eec280685174fbe368c4da0cb9cb8efd075
BUG/MEDIUM: http-act: Don't replace URI if path is not found or invalid

For replace-path, replace-pathq and replace-uri actions, we must take care
to not match on the selected element if it is not defined.

regex_exec_match2() function expects to be called with a defined
subject. However, if the request path is invalid or not found, the function
is called with a NULL subject, leading to a crash when compiled without the
PRCE/PCRE2 support.

For instance the following rules crashes HAProxy on a CONNECT request:

  http-request replace-path /short/(.) /\1

This patch must be backported as far as 2.0.
src/http_act.c