]> git.ipfire.org Git - thirdparty/ipxe.git/commit
[iphone] Add missing va_start()/va_end() around reused argument list
authorMichael Brown <mcb30@ipxe.org>
Tue, 24 Oct 2023 10:43:56 +0000 (11:43 +0100)
committerMichael Brown <mcb30@ipxe.org>
Tue, 24 Oct 2023 10:43:56 +0000 (11:43 +0100)
commit115707c0edebad65f87525fed583fef73880016d
tree189fa7a9b67bd10f2286b4366572d789e627a13c
parentff0f860483e344f1af633f94696ff7bc1854611f
[iphone] Add missing va_start()/va_end() around reused argument list

The ipair_tx() function uses a va_list twice (first to calculate the
formatted string length before allocation, then to construct the
string in the allocated buffer) but is missing the va_start() and
va_end() around the second usage.  This is undefined behaviour that
happens to work on some build platforms.

Fix by adding the missing va_start() and va_end() around the second
usage of the variadic argument list.

Reported-by: Andreas Hammarskjöld <andreas@2PintSoftware.com>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
src/drivers/net/iphone.c