]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
gpiolib: devres: release GPIOs in devm_gpiod_put_array()
authorAndré Draszik <andre.draszik@linaro.org>
Tue, 15 Jul 2025 16:00:20 +0000 (17:00 +0100)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Thu, 17 Jul 2025 07:22:46 +0000 (09:22 +0200)
commit11ff5e06e02326a7c87aaa73dbffaed94918261d
tree7aae8a8a7be3538ab6189f2126c6182320b71979
parente31c8f1db9c1df91af43012cb482e05a9339bbdf
gpiolib: devres: release GPIOs in devm_gpiod_put_array()

devm_gpiod_put_array() is meant to undo the effects of
devm_gpiod_get_array() - in particular, it should release the GPIOs
contained in the array acquired with the latter. It is meant to be the
resource-managed version of gpiod_put_array(), and it should behave
similar to the non-array version devm_gpiod_put().

Since commit d1d52c6622a6 ("gpiolib: devres: Finish the conversion to
use devm_add_action()") it doesn't do that anymore, it just removes the
devres action and frees associated memory, but it doesn't actually
release the GPIOs.

Fix by switching from devm_remove_action() to devm_release_action(),
which will in addition invoke the action to release the GPIOs.

Fixes: d1d52c6622a6 ("gpiolib: devres: Finish the conversion to use devm_add_action()")
Signed-off-by: André Draszik <andre.draszik@linaro.org>
Reported-by: Wattson CI <wattson-external@google.com>
Reported-by: Samuel Wu <wusamuel@google.com>
Link: https://lore.kernel.org/r/20250715-gpiolib-devres-put-array-fix-v1-1-970d82a8c887@linaro.org
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpiolib-devres.c