]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ASoC: codecs: wsa884x: fix codec initialisation
authorJohan Hovold <johan@kernel.org>
Fri, 2 Jan 2026 11:14:12 +0000 (12:14 +0100)
committerMark Brown <broonie@kernel.org>
Mon, 5 Jan 2026 13:14:35 +0000 (13:14 +0000)
commit120f3e6ff76209ee2f62a64e5e7e9d70274df42b
tree0e561cb1aaf29c455a0f4761fd6acb1d0528cc30
parent29d71b8a5a40708b3eed9ba4953bfc2312c9c776
ASoC: codecs: wsa884x: fix codec initialisation

The soundwire update_status() callback may be called multiple times with
the same ATTACHED status but initialisation should only be done when
transitioning from UNATTACHED to ATTACHED.

Fix the inverted hw_init flag which was set to false instead of true
after initialisation which defeats its purpose and may result in
repeated unnecessary initialisation.

Similarly, the initial state of the flag was also inverted so that the
codec would only be initialised and brought out of regmap cache only
mode if its status first transitions to UNATTACHED.

Fixes: aa21a7d4f68a ("ASoC: codecs: wsa884x: Add WSA884x family of speakers")
Cc: stable@vger.kernel.org # 6.5
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Tested-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Link: https://patch.msgid.link/20260102111413.9605-4-johan@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wsa884x.c