]> git.ipfire.org Git - thirdparty/libvirt.git/commit
Revert "networkAllocateActualDevice: Set QoS for bridgeless networks too"
authorMichal Privoznik <mprivozn@redhat.com>
Wed, 29 Jan 2014 17:38:54 +0000 (18:38 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Wed, 29 Jan 2014 18:01:19 +0000 (19:01 +0100)
commit122cd16982b30dfd54731dd9f353e54f0e5628b8
tree4de61a26f807c19369b946b6a76723b5c0393940
parent7bcbb53e18e02605a56b2b64ecf041f9df7a75a5
Revert "networkAllocateActualDevice: Set QoS for bridgeless networks too"

This reverts commit 2996e6be19a13199ded7c2aa21039cca97318e01
and some parts of 2636dc8c4de83cd37bc0680a6fbc3f6d25023bd7.

The former one tried to implement QoS setting on bridgeless networks.
However, as discussed upstream [1], the patch is far away from being
useful in even a single case. The whole idea of network QoS is to have
aggregated limits over several interfaces. This patch is doing
completely the opposite when merging two QoS settings (from the network
and the domain interface) into one which is then set at the domain
interface itself, not the network.

The latter one is the test for the previous one. Now none of them makes
sense.

1: https://www.redhat.com/archives/libvir-list/2014-January/msg01441.html

Conflicts:
tests/virnetdevbandwidthtest.c: New test has been introduced since
    then.
src/libvirt_private.syms
src/network/bridge_driver.c
src/util/virnetdevbandwidth.c
src/util/virnetdevbandwidth.h
tests/virnetdevbandwidthtest.c