]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
btrfs: Remove redundant extent_buffer_get in get_old_root
authorNikolay Borisov <nborisov@suse.com>
Wed, 15 Aug 2018 15:26:53 +0000 (18:26 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 12 Sep 2020 09:45:29 +0000 (11:45 +0200)
commit123597681e8928a8abe97e1f598e3ec6c6aeb2e5
treede060dabcdd42cc47bb961e9b7dfdfe7b4e3178f
parentd39a5df70ab9a010ad0fc999e2888529e63bb2ee
btrfs: Remove redundant extent_buffer_get in get_old_root

[ Upstream commit 6c122e2a0c515cfb3f3a9cefb5dad4cb62109c78 ]

get_old_root used used only by btrfs_search_old_slot to initialise the
path structure. The old root is always a cloned buffer (either via alloc
dummy or via btrfs_clone_extent_buffer) and its reference count is 2: 1
from allocation, 1 from extent_buffer_get call in get_old_root.

This latter explicit ref count acquire operation is in fact unnecessary
since the semantic is such that the newly allocated buffer is handed
over to the btrfs_path for lifetime management. Considering this just
remove the extra extent_buffer_get in get_old_root.

Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/btrfs/ctree.c