]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
CIFS: Fix a possible memory corruption during reconnect
authorPavel Shilovsky <pshilov@microsoft.com>
Fri, 4 Nov 2016 18:50:31 +0000 (11:50 -0700)
committerJiri Slaby <jslaby@suse.cz>
Thu, 26 Jan 2017 16:38:56 +0000 (17:38 +0100)
commit123b228a09b90b50b0a9d6eb8294cf0c42efc029
tree1f14c5e62f2bc7faf9c7f694adfb41b7ddbdac7c
parent102ddf72e8b7b07af776b8b9245afb2f9ae4c578
CIFS: Fix a possible memory corruption during reconnect

commit 53e0e11efe9289535b060a51d4cf37c25e0d0f2b upstream.

We can not unlock/lock cifs_tcp_ses_lock while walking through ses
and tcon lists because it can corrupt list iterator pointers and
a tcon structure can be released if we don't hold an extra reference.
Fix it by moving a reconnect process to a separate delayed work
and acquiring a reference to every tcon that needs to be reconnected.
Also do not send an echo request on newly established connections.

Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
fs/cifs/cifsglob.h
fs/cifs/cifsproto.h
fs/cifs/connect.c
fs/cifs/smb2pdu.c
fs/cifs/smb2proto.h