]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ALSA: usb-audio: fix broken logic in snd_audigy2nx_led_update()
authorSergey Shtylyov <s.shtylyov@auroraos.dev>
Tue, 3 Feb 2026 16:15:57 +0000 (19:15 +0300)
committerTakashi Iwai <tiwai@suse.de>
Tue, 3 Feb 2026 17:13:46 +0000 (18:13 +0100)
commit124bdc6eccc8c5cba68fee00e01c084c116c4360
tree45dc2d06fd8a33ce4dcd6e349cf7a4db24c41471
parent826af7fa62e347464b1b4e0ba2fe19a92438084f
ALSA: usb-audio: fix broken logic in snd_audigy2nx_led_update()

When the support for the Sound Blaster X-Fi Surround 5.1 Pro was added,
the existing logic for the X-Fi Surround 5.1 in snd_audigy2nx_led_put()
was broken due to missing *else* before the added *if*: snd_usb_ctl_msg()
became incorrectly called twice and an error from first snd_usb_ctl_msg()
call ignored.  As the added snd_usb_ctl_msg() call was totally identical
to the existing one for the "plain" X-Fi Surround 5.1, just merge those
two *if* statements while fixing the broken logic...

Found by Linux Verification Center (linuxtesting.org) with the Svace static
analysis tool.

Fixes: 7cdd8d73139e ("ALSA: usb-audio - Add support for USB X-Fi S51 Pro")
Signed-off-by: Sergey Shtylyov <s.shtylyov@auroraos.dev>
Link: https://patch.msgid.link/20260203161558.18680-1-s.shtylyov@auroraos.dev
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/mixer_quirks.c