]> git.ipfire.org Git - thirdparty/openvpn.git/commit
Fix tls_ctx_client/server_new leaving error on OpenSSL error stack
authorArne Schwabe <arne@rfc2549.org>
Tue, 21 Apr 2020 10:11:22 +0000 (12:11 +0200)
committerGert Doering <gert@greenie.muc.de>
Wed, 22 Apr 2020 09:50:27 +0000 (11:50 +0200)
commit125654bfa6f99a251b581522182e85748dd8043a
tree8624d6ea8bc36c38fa49d9d5c3e00fc8971cb944
parent9b0dafca6c50b8bb51f4851bd1361773d2bcded0
Fix tls_ctx_client/server_new leaving error on OpenSSL error stack

In the corner case that the global OpenSSL has an invalid command like

MinProtocol = TLSv1.0

(due to OpenSSL's idiosyncrasies MinProtocol = TLSv1 would be correct)
the SSL_ctx_new function leaves the errors for parsing the config file
on the stack.

  OpenSSL: error:14187180:SSL routines:ssl_do_config:bad value

Since the later functions, especially the one of loading the
certificates expected a clean error this error got reported at the
wrong place.

Print the warnings with crypto_msg when we detect that we are in this
situation (this also clears the stack).

Debian Bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=958296

Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20200421101122.24284-1-arne@rfc2549.org>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg19802.html

Signed-off-by: Gert Doering <gert@greenie.muc.de>
(cherry picked from commit 75aa88af774abaa168bf72e43e1dbb57be14c044)
src/openvpn/ssl_openssl.c