]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
hfsplus: ensure sb->s_fs_info is always cleaned up
authorMehdi Ben Hadj Khelifa <mehdi.benhadjkhelifa@gmail.com>
Mon, 1 Dec 2025 22:23:07 +0000 (23:23 +0100)
committerViacheslav Dubeyko <slava@dubeyko.com>
Mon, 15 Dec 2025 23:18:26 +0000 (15:18 -0800)
commit126fb0ce99431126b44a6c360192668c818f641f
treed078a538faab22904d69ba76a7a09e12b884e77c
parent05ce49a902be15dc93854cbfc20161205a9ee446
hfsplus: ensure sb->s_fs_info is always cleaned up

When hfsplus was converted to the new mount api a bug was introduced by
changing the allocation pattern of sb->s_fs_info. If setup_bdev_super()
fails after a new superblock has been allocated by sget_fc(), but before
hfsplus_fill_super() takes ownership of the filesystem-specific s_fs_info
data it was leaked.

Fix this by freeing sb->s_fs_info in hfsplus_kill_super().

Cc: stable@vger.kernel.org
Fixes: 432f7c78cb00 ("hfsplus: convert hfsplus to use the new mount api")
Reported-by: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>
Tested-by: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Mehdi Ben Hadj Khelifa <mehdi.benhadjkhelifa@gmail.com>
Reviewed-by: Viacheslav Dubeyko <slava@dubeyko.com>
Signed-off-by: Viacheslav Dubeyko <slava@dubeyko.com>
Link: https://lore.kernel.org/r/20251201222843.82310-3-mehdi.benhadjkhelifa@gmail.com
Signed-off-by: Viacheslav Dubeyko <slava@dubeyko.com>
fs/hfsplus/super.c