]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix CLUSTER tuplesorts on abbreviated expressions.
authorPeter Geoghegan <pg@bowt.ie>
Thu, 21 Apr 2022 00:17:39 +0000 (17:17 -0700)
committerPeter Geoghegan <pg@bowt.ie>
Thu, 21 Apr 2022 00:17:39 +0000 (17:17 -0700)
commit1272630a249798a0fce6a00383c78f8129434523
tree406f7995eb25a5e35092e5514dd4f12f1f4f5091
parent8275ba773dfe3168115bb3d32728111d9c4becb6
Fix CLUSTER tuplesorts on abbreviated expressions.

CLUSTER sort won't use the datum1 SortTuple field when clustering
against an index whose leading key is an expression.  This makes it
unsafe to use the abbreviated keys optimization, which was missed by the
logic that sets up SortSupport state.  Affected tuplesorts output tuples
in a completely bogus order as a result (the wrong SortSupport based
comparator was used for the leading attribute).

This issue is similar to the bug fixed on the master branch by recent
commit cc58eecc5d.  But it's a far older issue, that dates back to the
introduction of the abbreviated keys optimization by commit 4ea51cdfe8.

Backpatch to all supported versions.

Author: Peter Geoghegan <pg@bowt.ie>
Author: Thomas Munro <thomas.munro@gmail.com>
Discussion: https://postgr.es/m/CA+hUKG+bA+bmwD36_oDxAoLrCwZjVtST2fqe=b4=qZcmU7u89A@mail.gmail.com
Backpatch: 10-
src/backend/utils/sort/tuplesort.c
src/test/regress/expected/cluster.out
src/test/regress/sql/cluster.sql