]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: usb: rtl8150: fix memory leak on usb_submit_urb() failure
authorDeepakkumar Karn <dkarn@redhat.com>
Tue, 16 Dec 2025 15:13:05 +0000 (20:43 +0530)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 23 Dec 2025 11:12:34 +0000 (12:12 +0100)
commit12cab1191d9890097171156d06bfa8d31f1e39c8
tree70c03927754ce283987b6a96c9b88d4e43100c78
parentdff94bc6072b420f39bd2213c0f349fd7a09363c
net: usb: rtl8150: fix memory leak on usb_submit_urb() failure

In async_set_registers(), when usb_submit_urb() fails, the allocated
  async_req structure and URB are not freed, causing a memory leak.

  The completion callback async_set_reg_cb() is responsible for freeing
  these allocations, but it is only called after the URB is successfully
  submitted and completes (successfully or with error). If submission
  fails, the callback never runs and the memory is leaked.

  Fix this by freeing both the URB and the request structure in the error
  path when usb_submit_urb() fails.

Reported-by: syzbot+8dd915c7cb0490fc8c52@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=8dd915c7cb0490fc8c52
Fixes: 4d12997a9bb3 ("drivers: net: usb: rtl8150: concurrent URB bugfix")
Signed-off-by: Deepakkumar Karn <dkarn@redhat.com>
Link: https://patch.msgid.link/20251216151304.59865-2-dkarn@redhat.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/usb/rtl8150.c