]> git.ipfire.org Git - thirdparty/squid.git/commit
Deduplicate transaction LogTags (#906)
authorEduard Bagdasaryan <eduard.bagdasaryan@measurement-factory.com>
Sun, 3 Oct 2021 11:33:43 +0000 (11:33 +0000)
committerSquid Anubis <squid-anubis@squid-cache.org>
Sun, 3 Oct 2021 12:18:58 +0000 (12:18 +0000)
commit12f5a662baf7fa0e393fa8fea4af84ea3d0883b6
tree76fe6dc2d4ca59ab278b04f8d7b3812f6776e14e
parent04add666dda3315cff093b49b58508a75112906c
Deduplicate transaction LogTags (#906)

...using ALE cache.code instead of its partial
ClientSideRequest::logType duplicate.

The need to de-duplicate these two LogTag members became apparent when
we tried to update/detail LogTags in forwarding code (e.g., to report
peer timeouts) and noticed that ALE cache.code value could be
overwritten by (stale) ClientSideRequest::logType information. Those
updates needed other significant changes, so we factored this small
stand-alone improvement out.

Fortunately, ClientSideRequest::logType lifetime does not exceed ALE's,
making ClientHttpRequest::logTags removal straightforward.

Also removed a paranoid TunnelStateData::al check after verifying that
the ALE pointer is never nil.
src/client_side.cc
src/client_side_reply.cc
src/client_side_request.cc
src/client_side_request.h
src/http/Stream.cc
src/stat.cc
src/tunnel.cc