]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
block, bfq: get extra ref to prevent a queue from being freed during a group move
authorPaolo Valente <paolo.valente@linaro.org>
Mon, 3 Feb 2020 10:40:56 +0000 (11:40 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 12 Mar 2020 06:18:22 +0000 (07:18 +0100)
commit13371a0fc55d20d92b140a8e005a7f72792dd474
tree448e39a5cc66eda41de80c5b99ace081b6c7a361
parentdb5f1fc99c3ea3f1248cedc47c77fe650d48e0b8
block, bfq: get extra ref to prevent a queue from being freed during a group move

[ Upstream commit ecedd3d7e19911ab8fe42f17b77c0a30fe7f4db3 ]

In bfq_bfqq_move(), the bfq_queue, say Q, to be moved to a new group
may happen to be deactivated in the scheduling data structures of the
source group (and then activated in the destination group). If Q is
referred only by the data structures in the source group when the
deactivation happens, then Q is freed upon the deactivation.

This commit addresses this issue by getting an extra reference before
the possible deactivation, and releasing this extra reference after Q
has been moved.

Tested-by: Chris Evich <cevich@redhat.com>
Tested-by: Oleksandr Natalenko <oleksandr@natalenko.name>
Signed-off-by: Paolo Valente <paolo.valente@linaro.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
block/bfq-cgroup.c