]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
tcpm: allow looking for role_sw device in the main node
authorArnaud Ferraris <arnaud.ferraris@collabora.com>
Mon, 5 Jan 2026 08:43:23 +0000 (09:43 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 7 Jan 2026 15:28:05 +0000 (16:28 +0100)
commit1366cd228b0c67b60a2c0c26ef37fe9f7cfedb7f
tree55e2889e1caab9cee6b64ee20b8e8d1bd73d5092
parent0ed91d47959cb7573c17e06487f0fb891d59dfb3
tcpm: allow looking for role_sw device in the main node

If ports are defined in the tcpc main node, fwnode_usb_role_switch_get()
returns an error, meaning usb_role_switch_get() (which would succeed)
never gets a chance to run as port->role_sw isn't NULL, causing a
regression on devices where this is the case.

Fix this by turning the NULL check into IS_ERR_OR_NULL(), so
usb_role_switch_get() can actually run and the device get properly probed.

Fixes: 2d8713f807a4 ("tcpm: switch check for role_sw device with fw_node")
Cc: stable <stable@kernel.org>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Reviewed-by: Dragan Simic <dsimic@manjaro.org>
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
Link: https://patch.msgid.link/20260105-fix-ppp-power-v2-1-6924f5a41224@collabora.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/tcpm/tcpm.c