]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
Revert "block/mq-deadline: use correct way to throttling write requests"
authorBart Van Assche <bvanassche@acm.org>
Wed, 13 Mar 2024 21:42:18 +0000 (14:42 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 3 Apr 2024 13:11:26 +0000 (15:11 +0200)
commit14184659f79c1c98ce494b90259410d84e64a7a6
tree7e1d980e33785875089a3a5b04ab7ec0e0764809
parent05ee20c397530f73f193ccd026373347ed7a8fe3
Revert "block/mq-deadline: use correct way to throttling write requests"

[ Upstream commit 256aab46e31683d76d45ccbedc287b4d3f3e322b ]

The code "max(1U, 3 * (1U << shift)  / 4)" comes from the Kyber I/O
scheduler. The Kyber I/O scheduler maintains one internal queue per hwq
and hence derives its async_depth from the number of hwq tags. Using
this approach for the mq-deadline scheduler is wrong since the
mq-deadline scheduler maintains one internal queue for all hwqs
combined. Hence this revert.

Cc: stable@vger.kernel.org
Cc: Damien Le Moal <dlemoal@kernel.org>
Cc: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Cc: Zhiguo Niu <Zhiguo.Niu@unisoc.com>
Fixes: d47f9717e5cf ("block/mq-deadline: use correct way to throttling write requests")
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20240313214218.1736147-1-bvanassche@acm.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
block/mq-deadline.c