]> git.ipfire.org Git - thirdparty/linux.git/commit
mfd: axp20x: Set explicit ID for regulator cell if no IRQ line is present
authorChen-Yu Tsai <wens@csie.org>
Tue, 1 Jul 2025 16:36:52 +0000 (00:36 +0800)
committerLee Jones <lee@kernel.org>
Thu, 24 Jul 2025 10:27:19 +0000 (11:27 +0100)
commit1421c3aff49914d83b83be2f9e17007ba4397dc9
tree0acad5458519b00f6ca8e4624359bc20f9d2eea2
parent147dea662eaaf2da54bc2ec4d65053325036d734
mfd: axp20x: Set explicit ID for regulator cell if no IRQ line is present

Originally an explicit ID for the AXP313/AXP323 regulator was set to
avoid a conflict with the primary AXP717 PMIC on Allwinner A523 family
boards.

This didn't entirely work since on some or all of these boards, the
interrupt line on this secondary PMIC was left unconnected, and thus
the driver would fall back to the generic "no interrupt; only regulators"
case, which didn't have the explicit ID set, thus undoing the intended
fix.

Also set an explicit ID for the regulator cell in the no IRQ generic
fall back case. This fixes the conflict for the AXP717 + AXP313/AXP323
case. For the actual single PMIC with no IRQ connected case, the ID does
not affect functionality, only the device naming of the regulator cell,
and by extension the name and path under sysfs.

Fixes: 249abf9b1e25 ("mfd: axp20x: Set explicit ID for AXP313 regulator")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Link: https://lore.kernel.org/r/20250701163652.252010-1-wens@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/mfd/axp20x.c