]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
virt: tdx-guest: Just leak decrypted memory on unrecoverable errors
authorLi RongQing <lirongqing@baidu.com>
Wed, 19 Jun 2024 11:18:01 +0000 (19:18 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 Jan 2025 09:34:22 +0000 (10:34 +0100)
commit1429ae7b7d4759a1e362456b8911c701bae655b4
tree99d4c3eb83e34445c465b88861b26ca7b5f5f587
parentb939f108e86b76119428a6fa4e92491e09ac7867
virt: tdx-guest: Just leak decrypted memory on unrecoverable errors

commit 27834971f616c5e154423c578fa95e0444444ce1 upstream.

In CoCo VMs it is possible for the untrusted host to cause
set_memory_decrypted() to fail such that an error is returned
and the resulting memory is shared. Callers need to take care
to handle these errors to avoid returning decrypted (shared)
memory to the page allocator, which could lead to functional
or security issues.

Leak the decrypted memory when set_memory_decrypted() fails,
and don't need to print an error since set_memory_decrypted()
will call WARN_ONCE().

Fixes: f4738f56d1dc ("virt: tdx-guest: Add Quote generation support using TSM_REPORTS")
Signed-off-by: Li RongQing <lirongqing@baidu.com>
Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Rick Edgecombe <rick.p.edgecombe@intel.com>
Reviewed-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/all/20240619111801.25630-1-lirongqing%40baidu.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/virt/coco/tdx-guest/tdx-guest.c