]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
perf srcline: Add missed addr2line closes
authorIan Rogers <irogers@google.com>
Thu, 1 Feb 2024 00:15:02 +0000 (16:15 -0800)
committerSasha Levin <sashal@kernel.org>
Tue, 26 Mar 2024 22:19:47 +0000 (18:19 -0400)
commit149ad69e002d769d477d0a19229ad392301f3f30
tree51370ba252a3dbe1fcae2a78c47441297d2fe636
parent3e72d9d98036c42a957fdce86478a96d8d934bdf
perf srcline: Add missed addr2line closes

[ Upstream commit c7ba9d18ae47924a6ea6a47ca139779f58eb83c0 ]

The child_process for addr2line sets in and out to -1 so that pipes
get created. It is the caller's responsibility to close the pipes,
finish_command doesn't do it. Add the missed closes.

Fixes: b3801e791231 ("perf srcline: Simplify addr2line subprocess")
Signed-off-by: Ian Rogers <irogers@google.com>
Cc: Ravi Bangoria <ravi.bangoria@amd.com>
Cc: James Clark <james.clark@arm.com>
Cc: Nick Desaulniers <ndesaulniers@google.com>
Cc: Nathan Chancellor <nathan@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: John Garry <john.g.garry@oracle.com>
Cc: Tom Rix <trix@redhat.com>
Cc: llvm@lists.linux.dev
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/r/20240201001504.1348511-8-irogers@google.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
tools/perf/util/srcline.c