]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
bpo-38686: fix HTTP Digest handling in request.py (#17045)
authorPypeBros <PypeBros@users.noreply.github.com>
Fri, 22 Nov 2019 23:19:08 +0000 (00:19 +0100)
committerSenthil Kumaran <skumaran@gatech.edu>
Fri, 22 Nov 2019 23:19:08 +0000 (15:19 -0800)
commit14a89c47983f2fb9e7fdf33c769e622eefd3a14a
tree8cf9024150bebf29ec828e6f694be09ef33e2cbf
parent3ae38cc181fe513abc09c8931f910eeb61bac60d
bpo-38686: fix HTTP Digest handling in request.py (#17045)

* fix HTTP Digest handling in request.py

There is a bug triggered when server replies to a request with `WWW-Authenticate: Digest` where `qop="auth,auth-int"` rather than mere `qop="auth"`. Having both `auth` and `auth-int` is legitimate according to the `qop-options` rule in §3.2.1 of [[https://www.ietf.org/rfc/rfc2617.txt|RFC 2617]]:
>      qop-options       = "qop" "=" <"> 1#qop-value <">
>      qop-value         = "auth" | "auth-int" | token
> **qop-options**: [...] If present, it is a quoted string **of one or more** tokens indicating the "quality of protection" values supported by the server.  The value `"auth"` indicates authentication; the value `"auth-int"` indicates authentication with integrity protection

This is description confirmed by the definition of the [//n//]`#`[//m//]//rule// extended-BNF pattern defined in §2.1 of [[https://www.ietf.org/rfc/rfc2616.txt|RFC 2616]] as 'a comma-separated list of //rule// with at least //n// and at most //m// items'.

When this reply is parsed by `get_authorization`, request.py only tests for identity with `'auth'`, failing to recognize it as one of the supported modes the server announced, and claims that `"qop 'auth,auth-int' is not supported"`.

* 📜🤖 Added by blurb_it.

* bpo-38686 review fix: remember why.

* fix trailing space in Lib/urllib/request.py

Co-Authored-By: Brandt Bucher <brandtbucher@gmail.com>
Lib/urllib/request.py
Misc/NEWS.d/next/Library/2019-11-06-15-26-15.bpo-38686.HNFBce.rst [new file with mode: 0644]