]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
dm bufio: update last_accessed when relinking a buffer
authorJoe Thornber <ejt@redhat.com>
Tue, 30 Sep 2014 08:32:46 +0000 (09:32 +0100)
committerJiri Slaby <jslaby@suse.cz>
Thu, 13 Nov 2014 18:02:20 +0000 (19:02 +0100)
commit15188b0745439aa1f686e6eb55cacabbe2ea0244
tree4d71596463077a671df1df75ae58357ec8e9f10b
parent579cd3110d9192bcb86b472c50253b90eb0571a9
dm bufio: update last_accessed when relinking a buffer

commit eb76faf53b1ff7a77ce3f78cc98ad392ac70c2a0 upstream.

The 'last_accessed' member of the dm_buffer structure was only set when
the the buffer was created.  This led to each buffer being discarded
after dm_bufio_max_age time even if it was used recently.  In practice
this resulted in all thinp metadata being evicted soon after being read
-- this is particularly problematic for metadata intensive workloads
like multithreaded small random IO.

'last_accessed' is now updated each time the buffer is moved to the head
of the LRU list, so the buffer is now properly discarded if it was not
used in dm_bufio_max_age time.

Signed-off-by: Joe Thornber <ejt@redhat.com>
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/md/dm-bufio.c