]> git.ipfire.org Git - thirdparty/libvirt.git/commit
snapshot: Store both config and live XML in the snapshot domain
authorMaxiwell S. Garcia <maxiwell@linux.ibm.com>
Thu, 29 Aug 2019 20:55:43 +0000 (17:55 -0300)
committerJiri Denemark <jdenemar@redhat.com>
Wed, 11 Sep 2019 11:09:45 +0000 (13:09 +0200)
commit152c165d34cb6dcd21d08427422850f406cd0643
tree0c8097e9792a6fa1b6274b5101fe8d57f9bbb0f1
parent720d98263e2c5864efb6a6e6e68e3b9f0dd04e63
snapshot: Store both config and live XML in the snapshot domain

The snapshot-create operation of running guests saves the live
XML and uses it to replace the active and inactive domain in
case of revert. So, the config XML is ignored by the snapshot
process. This commit changes it and adds the config XML in the
snapshot XML as the <inactiveDomain> entry.

In case of offline guest, the behavior remains the same and the
config XML is saved in the snapshot XML as <domain> entry. The
behavior of older snapshots of running guests, that don't have
the new <inactiveDomain>, remains the same too. The revert, in
this case, overrides both active and inactive domain with the
<domain> entry. So, the <inactiveDomain> in the snapshot XML is
not required to snapshot work, but it's useful to preserve the
config XML of running guests.

Signed-off-by: Maxiwell S. Garcia <maxiwell@linux.ibm.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Tested-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
src/conf/moment_conf.c
src/conf/moment_conf.h
src/conf/snapshot_conf.c
src/qemu/qemu_driver.c