]> git.ipfire.org Git - thirdparty/curl.git/commit
asyn-thread: fix cppcheck warning
authorJay Satiro <raysatiro@yahoo.com>
Sat, 2 May 2020 18:53:09 +0000 (14:53 -0400)
committerJay Satiro <raysatiro@yahoo.com>
Sat, 2 May 2020 19:03:39 +0000 (15:03 -0400)
commit153d581b7f1aa9810037b2bdd3428ca3de0ff59d
treebd4cd88eb76a7351081eb1e1aff5a437995486c3
parent85eda4e87aa54b6412a81f8544939430fc89b8d9
asyn-thread: fix cppcheck warning

- Check for NULL entry parameter before attempting to deref entry in
  Curl_resolver_is_resolved, like is already done in asyn-ares.

This is to silence cppcheck which does not seem to understand that
asyn-ares and asyn-thread have separate Curl_resolver_is_resolved
and those units are mutually exclusive. Prior to this change it warned
of a scenario where asyn-thread's Curl_resolver_is_resolved is called
with a NULL entry from asyn-ares, but that couldn't happen.

Reported-by: rl1987@users.noreply.github.com
Fixes https://github.com/curl/curl/issues/5326
lib/asyn-thread.c