]> git.ipfire.org Git - thirdparty/libvirt.git/commit
conf: put all guest-related HostdevDef data in one object
authorLaine Stump <laine@laine.org>
Tue, 24 Jan 2012 17:53:59 +0000 (12:53 -0500)
committerLaine Stump <laine@laine.org>
Mon, 30 Jan 2012 17:25:20 +0000 (12:25 -0500)
commit159f4d0b30ca9916a1b541a9ebcf560ffeca5330
tree0f3c2c8b32a4df2c545055d09aa1c5e7da3737b2
parentaaa6210f8169460147ad956509db3904baea62e3
conf: put all guest-related HostdevDef data in one object

To help consolidate the commonality between virDomainHostdevDef and
virDomainNetDef into as few members as possible (and because I
think it makes sense), this patch moves the rombar and bootIndex
members into the "info" member that is common to both (and to all the
other structs that use them).

It's a bit problematic that this gives rombar and bootIndex to many
device types that don't use them, but this is already the case for the
master and mastertype members of virDomainDeviceInfo, and is properly
commented as such in the definition.

Note that this opens the door to supporting rombar for other devices
that are attached to the guest PCI bus - virtio-blk-pci,
virtio-net-pci, various other network adapters - which which have that
capability in qemu, but previously had no support in libvirt.
src/conf/domain_conf.c
src/conf/domain_conf.h
src/qemu/qemu_command.c
src/qemu/qemu_driver.c