]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
target: Fix COMPARE_AND_WRITE with SG_TO_MEM_NOALLOC handling
authorNicholas Bellinger <nab@linux-iscsi.org>
Tue, 7 Apr 2015 21:53:27 +0000 (21:53 +0000)
committerJiri Slaby <jslaby@suse.cz>
Mon, 4 May 2015 09:50:10 +0000 (11:50 +0200)
commit15a557ae69ea1e86aa8db5c9a48f7406d9235b72
tree9e49185e3690903dd7e78308b455312d5be2d5c5
parent616d9390b1db74097735ac58346d164d2fa2d16b
target: Fix COMPARE_AND_WRITE with SG_TO_MEM_NOALLOC handling

commit c8e639852ad720499912acedfd6b072325fd2807 upstream.

This patch fixes a bug for COMPARE_AND_WRITE handling with
fabrics using SCF_PASSTHROUGH_SG_TO_MEM_NOALLOC.

It adds the missing allocation for cmd->t_bidi_data_sg within
transport_generic_new_cmd() that is used by COMPARE_AND_WRITE
for the initial READ payload, even if the fabric is already
providing a pre-allocated buffer for cmd->t_data_sg.

Also, fix zero-length COMPARE_AND_WRITE handling within the
compare_and_write_callback() and target_complete_ok_work()
to queue the response, skipping the initial READ.

This fixes COMPARE_AND_WRITE emulation with loopback, vhost,
and xen-backend fabric drivers using SG_TO_MEM_NOALLOC.

Reported-by: Christoph Hellwig <hch@lst.de>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/target/target_core_sbc.c
drivers/target/target_core_transport.c
include/target/target_core_base.h