]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mmc: omap: fix the maximum timeout setting
authorAaro Koskinen <aaro.koskinen@iki.fi>
Sat, 2 Feb 2019 22:14:33 +0000 (00:14 +0200)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 9 Jul 2019 21:04:06 +0000 (22:04 +0100)
commit15b800d8f60d6f063d627de612f01794a29982ed
tree66acd901d9485b469461445bc58de684374a17c9
parent8659048945a45cb840333e54851f54ef769c66e0
mmc: omap: fix the maximum timeout setting

commit a6327b5e57fdc679c842588c3be046c0b39cc127 upstream.

When running OMAP1 kernel on QEMU, MMC access is annoyingly noisy:

MMC: CTO of 0xff and 0xfe cannot be used!
MMC: CTO of 0xff and 0xfe cannot be used!
MMC: CTO of 0xff and 0xfe cannot be used!
[ad inf.]

Emulator warnings appear to be valid. The TI document SPRU680 [1]
("OMAP5910 Dual-Core Processor MultiMedia Card/Secure Data Memory Card
(MMC/SD) Reference Guide") page 36 states that the maximum timeout is 253
cycles and "0xff and 0xfe cannot be used".

Fix by using 0xfd as the maximum timeout.

Tested using QEMU 2.5 (Siemens SX1 machine, OMAP310), and also checked on
real hardware using Palm TE (OMAP310), Nokia 770 (OMAP1710) and Nokia N810
(OMAP2420) that MMC works as before.

[1] http://www.ti.com/lit/ug/spru680/spru680.pdf

Fixes: 730c9b7e6630f ("[MMC] Add OMAP MMC host driver")
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/mmc/host/omap.c