]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
tcp: Fix listen() regression in 4.14.303.
authorKuniyuki Iwashima <kuniyu@amazon.com>
Mon, 13 Feb 2023 20:45:48 +0000 (20:45 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 11 Mar 2023 15:26:55 +0000 (16:26 +0100)
commit1657dc23bb76239a748d5f0c3919156ae1d211f6
tree0e147074eacc51eb7d29914f15a4aee363085713
parent02266aeda1e4f49ba2260f2ab3b4e5f77e352b0a
tcp: Fix listen() regression in 4.14.303.

commit fdaf88531cfd17b2a710cceb3141ef6f9085ff40 upstream.

When we backport dadd0dcaa67d ("net/ulp: prevent ULP without clone op from
entering the LISTEN status"), we have accidentally backported a part of
7a7160edf1bf ("net: Return errno in sk->sk_prot->get_port().") and removed
err = -EADDRINUSE in inet_csk_listen_start().

Thus, listen() no longer returns -EADDRINUSE even if ->get_port() failed
as reported in [0].

We set -EADDRINUSE to err just before ->get_port() to fix the regression.

[0]: https://lore.kernel.org/stable/EF8A45D0-768A-4CD5-9A8A-0FA6E610ABF7@winter.cafe/

Reported-by: Winter <winter@winter.cafe>
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/ipv4/inet_connection_sock.c