]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
perf util: Fix perf_exe() buffer write past end
authorMiguel Martín Gil <miguel.martin.gil.uni@gmail.com>
Tue, 26 May 2026 11:08:52 +0000 (13:08 +0200)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Sat, 30 May 2026 00:17:25 +0000 (21:17 -0300)
commit167bef4df68635f8bfa2af9108351ee78536d7fb
tree9720cf0cb63ef6694cf6aaa91fe59cc696231b14
parent3dfaf02e554f63f9b4e68b69deda9617a1948993
perf util: Fix perf_exe() buffer write past end

perf_exe() passes len to readlink() and then unconditionally writes a
trailing NUL at buf[n]. If readlink() returns len, the write lands one
byte past the buffer.

Read at most len - 1 bytes and keep the existing NUL termination. Also
guard the fallback path for tiny buffers so copying "perf" cannot
overflow.

Reviewed-by: Ian Rogers <irogers@google.com>
Signed-off-by: Miguel Martín Gil <miguel.martin.gil.uni@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/util.c